test_output_presenter.py 40 KB

123456789101112131415161718192021222324252627282930313233343536373839404142434445464748495051525354555657585960616263646566676869707172737475767778798081828384858687888990919293949596979899100101102103104105106107108109110111112113114115116117118119120121122123124125126127128129130131132133134135136137138139140141142143144145146147148149150151152153154155156157158159160161162163164165166167168169170171172173174175176177178179180181182183184185186187188189190191192193194195196197198199200201202203204205206207208209210211212213214215216217218219220221222223224225226227228229230231232233234235236237238239240241242243244245246247248249250251252253254255256257258259260261262263264265266267268269270271272273274275276277278279280281282283284285286287288289290291292293294295296297298299300301302303304305306307308309310311312313314315316317318319320321322323324325326327328329330331332333334335336337338339340341342343344345346347348349350351352353354355356357358359360361362363364365366367368369370371372373374375376377378379380381382383384385386387388389390391392393394395396397398399400401402403404405406407408409410411412413414415416417418419420421422423424425426427428429430431432433434435436437438439440441442443444445446447448449450451452453454455456457458459460461462463464465466467468469470471472473474475476477478479480481482483484485486487488489490491492493494495496497498499500501502503504505506507508509510511512513514515516517518519520521522523524525526527528529530531532533534535536537538539540541542543544545546547548549550551552553554555556557558559560561562563564565566567568569570571572573574575576577578579580581582583584585586587588589590591592593594595596597598599600601602603604605606607608609610611612613614615616617618619620621622623624625626627628629630631632633634635636637638639640641642643644645646647648649650651652653654655656657658659660661662663664665666667668669670671672673674675676677678679680681682683684685686687688689690691692693694695696697698699700701702703704705706707708709710711712713714715716717718719720721722723724725726727728729730731732733734735736737738739740741742743744745746747748749750751752753754755756757758759760761762763764765766767768769770771772773774775776777778779780781782783784785786787788789790791792793794795796797798799800801802803804805806807808809810811812813814815816817818819820821822823824825826827828829830831832833834835836837838839840841842843844845846847848849850851852853854855856857858859860861862863864865866867868869870871872873874875876877878879880881882883884885886887888889890891892893894895896897898899900901902903904905906907908909910911912913914915916917918919920921922923924925926927928929930931932933934935936937938939940941942943944945946947948949950951952953954955956957958959960961962963964965966967968969970971972973974975976977978979980981982983984985986987988989990991992993994995996997998999100010011002100310041005100610071008100910101011101210131014101510161017101810191020102110221023102410251026102710281029
  1. import json
  2. import unittest
  3. from services.output_presenter import OutputPresenter
  4. from tools.export_out_of_province_port_data import ExportOutOfProvincePortDataTool
  5. from tools.export_pending_outbound_orders import ExportPendingOutboundOrdersTool
  6. from tools.list_order_filter_options import ListOrderFilterOptionsTool
  7. from tools.list_customer_filter_options import ListCustomerFilterOptionsTool
  8. from tools.list_pending_outbound_export_filter_options import (
  9. ListPendingOutboundExportFilterOptionsTool,
  10. )
  11. from tools.query_order import QueryOrderTool
  12. from tools.query_order_exact import QueryOrderExactTool
  13. from tools.query_track import QueryTrackTool
  14. from tools.query_customer_list import QueryCustomerListTool
  15. class OutputPresenterTest(unittest.TestCase):
  16. def setUp(self):
  17. self.presenter = OutputPresenter()
  18. def test_customer_list_uses_fixed_17_column_safe_table(self):
  19. keys = [
  20. 'customer_name', 'customer_code', 'create_time', 'business_type',
  21. 'customer_attribute', 'customer_source', 'first_inbound_date',
  22. 'last_inbound_date', 'active_status', 'contract_status',
  23. 'contract_validity', 'credit_limit', 'currency_code',
  24. 'billing_modes', 'sales_name', 'merchandiser_name',
  25. 'department_name',
  26. ]
  27. result = self.presenter.present('query_customer_list', {
  28. 'code': 'MCP_0000',
  29. 'data': {
  30. 'summary': '当前页返回1个客户',
  31. 'columns': [{'key': key, 'name': '不可信名称'} for key in keys],
  32. 'records': [dict(
  33. (key, [
  34. {'business_type': '头程业务', 'settlement_mode': '月结'},
  35. {'business_type': '转运业务', 'settlement_mode': '票结'},
  36. ] if key == 'billing_modes' else '值{0}'.format(index))
  37. for index, key in enumerate(keys)
  38. )],
  39. 'tips': [],
  40. },
  41. 'meta': {
  42. 'page': 1, 'limit': 20, 'has_more': False,
  43. 'request_id': 'rq_customer',
  44. },
  45. })
  46. self.assertFalse(result['is_error'])
  47. self.assertEqual(17, len(result['structured_content']['headers']))
  48. self.assertEqual('客户名称', result['structured_content']['headers'][0]['label'])
  49. self.assertEqual('事业部', result['structured_content']['headers'][-1]['label'])
  50. self.assertEqual([
  51. {'业务类型': '头程业务', '结算模式': '月结'},
  52. {'业务类型': '转运业务', '结算模式': '票结'},
  53. ], result['structured_content']['rows'][0][13])
  54. self.assertEqual({
  55. 'mode': 'complete',
  56. 'allow_summary': False,
  57. 'allow_omit_records': False,
  58. 'allow_omit_empty_fields': False,
  59. 'allow_rename_fields': False,
  60. 'preserve_record_order': True,
  61. 'required_field_count': 17,
  62. 'returned_record_count': 1,
  63. 'required_value_count': 17,
  64. 'instruction': '最终回复必须逐条展示全部记录及全部17个字段,不得摘要、省略或改写',
  65. }, result['structured_content']['display_rules'])
  66. self.assertIn('完整客户数据,禁止摘要、合并、隐藏字段或省略空字段。', result['text'])
  67. self.assertIn('本页记录数:1;每条字段数:17;应展示字段值总数:17。', result['text'])
  68. self.assertIn('展示完整性校验:已提供1条客户的全部17个字段。', result['text'])
  69. serialized = json.dumps(result, ensure_ascii=False)
  70. self.assertNotIn('customer_name', serialized)
  71. self.assertNotIn('不可信名称', serialized)
  72. def test_customer_list_rejects_malformed_structured_billing_modes(self):
  73. keys = list(self.presenter.TABLE_COLUMNS['query_customer_list'])
  74. for billing_modes in (
  75. '头程业务:月结',
  76. [{'business_type': '头程业务'}],
  77. [{'business_type': '头程业务', 'settlement_mode': '月结', 'id': 1}],
  78. [{'business_type': '', 'settlement_mode': '月结'}],
  79. ):
  80. with self.subTest(billing_modes=billing_modes):
  81. record = dict((key, '') for key in keys)
  82. record['billing_modes'] = billing_modes
  83. result = self.presenter.present('query_customer_list', {
  84. 'code': 'MCP_0000',
  85. 'data': {
  86. 'summary': '',
  87. 'columns': [{'key': key, 'name': key} for key in keys],
  88. 'records': [record],
  89. 'tips': [],
  90. },
  91. 'meta': {'page': 1, 'limit': 20, 'has_more': False},
  92. })
  93. self.assertTrue(result['is_error'])
  94. record = dict((key, '') for key in keys)
  95. record['billing_modes'] = []
  96. record['customer_name'] = ['不允许的嵌套值']
  97. result = self.presenter.present('query_customer_list', {
  98. 'code': 'MCP_0000',
  99. 'data': {
  100. 'summary': '',
  101. 'columns': [{'key': key, 'name': key} for key in keys],
  102. 'records': [record],
  103. 'tips': [],
  104. },
  105. 'meta': {'page': 1, 'limit': 20, 'has_more': False},
  106. })
  107. self.assertTrue(result['is_error'])
  108. def test_customer_list_fails_closed_on_incomplete_columns_or_bad_meta(self):
  109. base = {
  110. 'code': 'MCP_0000',
  111. 'data': {
  112. 'summary': '',
  113. 'columns': [{'key': 'customer_name', 'name': '客户名称'}],
  114. 'records': [], 'tips': [],
  115. },
  116. 'meta': {'page': 1, 'limit': 20, 'has_more': False},
  117. }
  118. self.assertTrue(self.presenter.present('query_customer_list', base)['is_error'])
  119. keys = list(self.presenter.TABLE_COLUMNS['query_customer_list'])
  120. base['data']['columns'] = [{'key': key, 'name': key} for key in keys]
  121. base['meta']['has_more'] = 'false'
  122. self.assertTrue(self.presenter.present('query_customer_list', base)['is_error'])
  123. def test_customer_list_rejects_record_with_internal_field(self):
  124. keys = list(self.presenter.TABLE_COLUMNS['query_customer_list'])
  125. record = dict((key, '') for key in keys)
  126. record['customer_id'] = 9
  127. result = self.presenter.present('query_customer_list', {
  128. 'code': 'MCP_0000',
  129. 'data': {
  130. 'summary': '', 'columns': [{'key': key, 'name': key} for key in keys],
  131. 'records': [record], 'tips': [],
  132. },
  133. 'meta': {'page': 1, 'limit': 20, 'has_more': False},
  134. })
  135. self.assertTrue(result['is_error'])
  136. def test_customer_options_use_safe_shape_and_reject_unknown_fields(self):
  137. result = self.presenter.present('list_customer_filter_options', {
  138. 'code': 'MCP_0000',
  139. 'data': {'records': [{'value': 7, 'label': '客户甲-C001', 'code': 'C001'}]},
  140. 'meta': {'page': 1, 'limit': 20, 'has_more': False},
  141. })
  142. self.assertFalse(result['is_error'])
  143. self.assertEqual([[7, '客户甲-C001', 'C001']], result['structured_content']['rows'])
  144. malformed = self.presenter.present('list_customer_filter_options', {
  145. 'code': 'MCP_0000',
  146. 'data': {'records': [{
  147. 'value': 7, 'label': '客户甲', 'code': 'C001', 'admin_id': 99,
  148. }]},
  149. 'meta': {'page': 1, 'limit': 20, 'has_more': False},
  150. })
  151. self.assertTrue(malformed['is_error'])
  152. self.assertNotIn('99', malformed['text'])
  153. def test_customer_options_reject_malformed_records_and_pagination(self):
  154. def present(records, meta):
  155. return self.presenter.present('list_customer_filter_options', {
  156. 'code': 'MCP_0000', 'data': {'records': records}, 'meta': meta,
  157. })
  158. good_meta = {'page': 1, 'limit': 20, 'has_more': False}
  159. bad_records = [
  160. 'record',
  161. {'value': 1, 'label': '客户甲'},
  162. {'value': True, 'label': '客户甲', 'code': ''},
  163. {'value': '1', 'label': '客户甲', 'code': ''},
  164. {'value': 0, 'label': '客户甲', 'code': ''},
  165. {'value': 1, 'label': 2, 'code': ''},
  166. {'value': 1, 'label': ' ', 'code': ''},
  167. {'value': 1, 'label': '客户甲', 'code': 3},
  168. ]
  169. for record in bad_records:
  170. with self.subTest(record=record):
  171. self.assertTrue(present([record], good_meta)['is_error'])
  172. self.assertTrue(present('records', good_meta)['is_error'])
  173. self.assertTrue(self.presenter.present('list_customer_filter_options', {
  174. 'code': 'MCP_0000', 'data': {'records': [], 'extra': 1}, 'meta': good_meta,
  175. })['is_error'])
  176. bad_meta = [
  177. None, {},
  178. {'page': True, 'limit': 20, 'has_more': False},
  179. {'page': '1', 'limit': 20, 'has_more': False},
  180. {'page': 0, 'limit': 20, 'has_more': False},
  181. {'page': 1, 'limit': True, 'has_more': False},
  182. {'page': 1, 'limit': '20', 'has_more': False},
  183. {'page': 1, 'limit': 0, 'has_more': False},
  184. {'page': 1, 'limit': 101, 'has_more': False},
  185. {'page': 1, 'limit': 20, 'has_more': 'false'},
  186. ]
  187. for meta in bad_meta:
  188. with self.subTest(meta=meta):
  189. self.assertTrue(present([], meta)['is_error'])
  190. def test_customer_tools_are_safe_and_total_is_24(self):
  191. self.assertTrue(self.presenter.handles(QueryCustomerListTool.name))
  192. self.assertTrue(self.presenter.handles(ListCustomerFilterOptionsTool.name))
  193. self.assertEqual(33, len(self.presenter.SAFE_TOOLS))
  194. def test_exact_order_uses_labels_and_drops_internal_fields(self):
  195. result = self.presenter.present(
  196. 'query_order_exact',
  197. {
  198. 'code': 'MCP_0000',
  199. 'data': {
  200. 'summary': '当前页返回 1 条订单',
  201. 'columns': [
  202. {'key': 'order_number', 'name': '订单号'},
  203. {
  204. 'key': 'tracking_number',
  205. 'name': '快递单号',
  206. 'description': '承运商跟踪号码',
  207. },
  208. ],
  209. 'records': [{
  210. 'order_number': 'SO001',
  211. 'tracking_number': 'TN001',
  212. 'order_id': 99,
  213. 'time_zone': '8.00',
  214. }],
  215. 'tips': [],
  216. },
  217. 'meta': {
  218. 'page': 1,
  219. 'limit': 20,
  220. 'has_more': False,
  221. 'request_id': 'rq_exact',
  222. },
  223. },
  224. )
  225. self.assertFalse(result['is_error'])
  226. self.assertEqual(
  227. [
  228. {'label': '订单号'},
  229. {'label': '快递单号', 'description': '承运商跟踪号码'},
  230. ],
  231. result['structured_content']['headers'],
  232. )
  233. self.assertEqual(
  234. [['SO001', 'TN001']],
  235. result['structured_content']['rows'],
  236. )
  237. self.assertEqual(
  238. {'page': 1, 'limit': 20, 'has_more': False},
  239. result['structured_content']['pagination'],
  240. )
  241. self.assertEqual({'request_id': 'rq_exact'}, result['meta'])
  242. serialized = json.dumps(result, ensure_ascii=False)
  243. self.assertNotIn('order_number', serialized)
  244. self.assertNotIn('tracking_number', serialized)
  245. self.assertNotIn('order_id', serialized)
  246. self.assertNotIn('time_zone', serialized)
  247. self.assertIn('订单号', result['text'])
  248. self.assertIn('SO001', result['text'])
  249. def test_table_tools_reject_unknown_backend_columns(self):
  250. for tool_name in (
  251. 'query_order_exact',
  252. 'query_track',
  253. 'query_customs_declaration_files',
  254. ):
  255. with self.subTest(tool_name=tool_name):
  256. result = self.presenter.present(
  257. tool_name,
  258. {
  259. 'code': 'MCP_0000',
  260. 'data': {
  261. 'columns': [
  262. {'key': 'order_id', 'name': '内部订单ID'},
  263. ],
  264. 'records': [{'order_id': 99}],
  265. },
  266. },
  267. )
  268. self.assertTrue(result['is_error'])
  269. self.assertEqual(
  270. '工具返回格式异常',
  271. result['structured_content']['message'],
  272. )
  273. self.assertNotIn('99', result['text'])
  274. def test_table_tools_use_fixed_labels_instead_of_backend_labels(self):
  275. result = self.presenter.present(
  276. 'query_customs_declaration_files',
  277. {
  278. 'code': 'MCP_0000',
  279. 'data': {
  280. 'columns': [
  281. {'key': 'order_number', 'name': '内部名称'},
  282. ],
  283. 'records': [{'order_number': 'ORD001'}],
  284. },
  285. },
  286. )
  287. self.assertFalse(result['is_error'])
  288. self.assertEqual(
  289. [{'label': '订单号'}],
  290. result['structured_content']['headers'],
  291. )
  292. self.assertNotIn('内部名称', result['text'])
  293. def test_table_tool_without_column_definition_fails_closed(self):
  294. definition = self.presenter.TABLE_COLUMNS.pop('query_track')
  295. try:
  296. result = self.presenter.present(
  297. 'query_track',
  298. {
  299. 'code': 'MCP_0000',
  300. 'data': {
  301. 'columns': [{'key': 'status', 'name': '轨迹节点'}],
  302. 'records': [],
  303. },
  304. },
  305. )
  306. finally:
  307. self.presenter.TABLE_COLUMNS['query_track'] = definition
  308. self.assertTrue(result['is_error'])
  309. self.assertEqual(
  310. '工具返回格式异常',
  311. result['structured_content']['message'],
  312. )
  313. def test_table_missing_value_is_empty_and_fixed_labels_are_used(self):
  314. result = self.presenter.present(
  315. 'query_track',
  316. {
  317. 'code': '0',
  318. 'data': {
  319. 'columns': [
  320. {'key': 'status', 'name': '状态'},
  321. {'key': 'content', 'name': '状态'},
  322. ],
  323. 'records': [{'status': '已发货'}],
  324. 'tips': ['仅展示已有轨迹'],
  325. },
  326. 'meta': {'request_id': 'rq_track'},
  327. },
  328. )
  329. self.assertEqual(
  330. [
  331. {
  332. 'label': '轨迹节点',
  333. 'description': '轨迹状态,如:开始集港、离港放行、清关、配送等',
  334. },
  335. {'label': '轨迹内容', 'description': '详细描述'},
  336. ],
  337. result['structured_content']['headers'],
  338. )
  339. self.assertEqual([['已发货', '']], result['structured_content']['rows'])
  340. self.assertEqual(['仅展示已有轨迹'], result['structured_content']['tips'])
  341. def test_empty_table_keeps_safe_headers_and_tips(self):
  342. result = self.presenter.present(
  343. 'query_track',
  344. {
  345. 'code': 'MCP_0000',
  346. 'data': {
  347. 'columns': [{'key': 'status', 'name': '轨迹节点'}],
  348. 'records': [],
  349. 'tips': ['未查询到轨迹信息'],
  350. },
  351. 'meta': {'page': 1, 'limit': 5, 'total': 0},
  352. },
  353. )
  354. self.assertEqual(
  355. [{
  356. 'label': '轨迹节点',
  357. 'description': '轨迹状态,如:开始集港、离港放行、清关、配送等',
  358. }],
  359. result['structured_content']['headers'],
  360. )
  361. self.assertEqual([], result['structured_content']['rows'])
  362. self.assertIn('未查询到轨迹信息', result['text'])
  363. without_tips = self.presenter.present(
  364. 'query_track',
  365. {
  366. 'code': 'MCP_0000',
  367. 'data': {
  368. 'columns': [{'key': 'status', 'name': '轨迹节点'}],
  369. 'records': [],
  370. 'tips': 'not-a-list',
  371. },
  372. },
  373. )
  374. self.assertNotIn('tips', without_tips['structured_content'])
  375. def test_filter_options_preserve_values_for_follow_up_calls(self):
  376. result = self.presenter.present(
  377. 'list_order_filter_options',
  378. {
  379. 'code': 'MCP_0000',
  380. 'data': {
  381. 'records': [
  382. {'value': 101, 'label': '客户甲', 'code': 'CUS-A'},
  383. {'value': -1, 'label': '客户仓', 'code': '-1'},
  384. ],
  385. },
  386. 'meta': {'page': 2, 'limit': 20, 'has_more': True},
  387. },
  388. )
  389. self.assertEqual(
  390. [[101, '客户甲', 'CUS-A'], [-1, '客户仓', '-1']],
  391. result['structured_content']['rows'],
  392. )
  393. self.assertEqual(
  394. ['可传值', '显示名称', '业务编码'],
  395. [item['label'] for item in result['structured_content']['headers']],
  396. )
  397. self.assertNotIn('"value"', json.dumps(result, ensure_ascii=False))
  398. def test_pending_filter_options_use_same_safe_shape(self):
  399. result = self.presenter.present(
  400. 'list_pending_outbound_export_filter_options',
  401. {
  402. 'code': 'MCP_0000',
  403. 'data': {'records': [{'value': 'US', 'label': '美国', 'code': 'US'}]},
  404. 'meta': {},
  405. },
  406. )
  407. self.assertEqual([['US', '美国', 'US']], result['structured_content']['rows'])
  408. def test_export_submission_returns_only_safe_queued_task(self):
  409. for tool_name in (
  410. 'export_pending_outbound_orders',
  411. 'export_out_of_province_port_data',
  412. 'export_receivable_cost_list',
  413. 'export_pallet_data',
  414. 'export_container_timeliness_report',
  415. ):
  416. with self.subTest(tool_name=tool_name):
  417. result = self.presenter.present(
  418. tool_name,
  419. {
  420. 'code': 'MCP_0000',
  421. 'data': {
  422. 'task_ref': 'mexp_abc',
  423. 'status': 'queued',
  424. 'retry_after_seconds': 10,
  425. },
  426. 'meta': {'request_id': 'rq_export'},
  427. },
  428. )
  429. self.assertEqual(
  430. {
  431. 'task_ref': 'mexp_abc',
  432. 'status': 'queued',
  433. 'retry_after_seconds': 10,
  434. },
  435. result['structured_content']['task'],
  436. )
  437. self.assertNotIn('file_url', json.dumps(result, ensure_ascii=False))
  438. def test_export_task_query_presents_all_known_states(self):
  439. queued = self.presenter.present(
  440. 'query_export_task',
  441. {
  442. 'code': 'MCP_0000',
  443. 'data': {
  444. 'task_ref': 'mexp_abc',
  445. 'status': 'queued',
  446. 'retry_after_seconds': 10,
  447. },
  448. },
  449. )
  450. running = self.presenter.present(
  451. 'query_export_task',
  452. {
  453. 'code': 'MCP_0000',
  454. 'data': {
  455. 'task_ref': 'mexp_abc',
  456. 'status': 'running',
  457. 'retry_after_seconds': 10,
  458. },
  459. },
  460. )
  461. completed = self.presenter.present(
  462. 'query_export_task',
  463. {
  464. 'code': 'MCP_0000',
  465. 'data': {
  466. 'task_ref': 'mexp_abc',
  467. 'status': 'completed',
  468. 'files': [{
  469. 'label': 'port.zip',
  470. 'url': 'https://files.test/port.zip',
  471. }],
  472. },
  473. },
  474. )
  475. failed = self.presenter.present(
  476. 'query_export_task',
  477. {
  478. 'code': 'MCP_0000',
  479. 'data': {'task_ref': 'mexp_abc', 'status': 'failed'},
  480. },
  481. )
  482. self.assertEqual('queued', queued['structured_content']['task']['status'])
  483. self.assertEqual('running', running['structured_content']['task']['status'])
  484. self.assertEqual(
  485. 'https://files.test/port.zip',
  486. completed['structured_content']['files'][0]['url'],
  487. )
  488. self.assertEqual('failed', failed['structured_content']['task']['status'])
  489. def test_export_task_unknown_or_malformed_states_fail_closed(self):
  490. cases = (
  491. {
  492. 'task_ref': 123,
  493. 'status': 'queued',
  494. 'retry_after_seconds': 10,
  495. },
  496. {'task_ref': 'mexp_abc', 'status': 'unknown'},
  497. {'task_ref': 'mexp_abc', 'status': 'queued'},
  498. {
  499. 'task_ref': 'mexp_abc',
  500. 'status': 'queued',
  501. 'retry_after_seconds': 0,
  502. },
  503. {
  504. 'task_ref': 'mexp_abc',
  505. 'status': 'running',
  506. 'retry_after_seconds': 10,
  507. 'files': [],
  508. },
  509. {
  510. 'task_ref': 'mexp_abc',
  511. 'status': 'completed',
  512. 'files': None,
  513. },
  514. {
  515. 'task_ref': 'mexp_abc',
  516. 'status': 'completed',
  517. 'files': ['bad'],
  518. },
  519. {
  520. 'task_ref': 'mexp_abc',
  521. 'status': 'completed',
  522. 'files': [{'label': 'bad', 'url': None}],
  523. },
  524. {
  525. 'task_ref': 'mexp_abc',
  526. 'status': 'completed',
  527. 'files': [{'label': 'bad', 'url': 'javascript:alert(1)'}],
  528. },
  529. {
  530. 'task_ref': 'mexp_abc',
  531. 'status': 'completed',
  532. 'files': [],
  533. 'extra': True,
  534. },
  535. {
  536. 'task_ref': 'mexp_abc',
  537. 'status': 'failed',
  538. 'remark': 'secret',
  539. },
  540. )
  541. for data in cases:
  542. with self.subTest(data=data):
  543. result = self.presenter.present(
  544. 'query_export_task',
  545. {'code': 'MCP_0000', 'data': data},
  546. )
  547. self.assertTrue(result['is_error'])
  548. def test_export_task_rejects_unsafe_download_urls(self):
  549. urls = (
  550. 'https://user:pass@files.test/a.xlsx',
  551. 'https://files.test/a file.xlsx',
  552. 'https://files.test/a\x00.xlsx',
  553. 'http:foo',
  554. 'ftp://files.test/a.xlsx',
  555. 'https://files.test:bad/a.xlsx',
  556. 'https://files.test:99999/a.xlsx',
  557. 'https://files.test\\evil/a.xlsx',
  558. )
  559. for url in urls:
  560. with self.subTest(url=repr(url)):
  561. result = self.presenter.present(
  562. 'query_export_task',
  563. {
  564. 'code': 'MCP_0000',
  565. 'data': {
  566. 'task_ref': 'mexp_abc',
  567. 'status': 'completed',
  568. 'files': [{'label': 'a.xlsx', 'url': url}],
  569. },
  570. },
  571. )
  572. self.assertTrue(result['is_error'])
  573. def test_known_parameter_error_uses_business_label(self):
  574. result = self.presenter.present(
  575. 'query_track',
  576. {
  577. 'code': 'MCP_1401',
  578. 'msg': 'tracking_number is required',
  579. 'data': {'tracking_number': 'bad'},
  580. 'meta': {'request_id': 'rq_error'},
  581. },
  582. )
  583. self.assertTrue(result['is_error'])
  584. self.assertEqual('快递单号参数不正确', result['structured_content']['message'])
  585. self.assertNotIn('tracking_number', json.dumps(result, ensure_ascii=False))
  586. self.assertEqual({'request_id': 'rq_error'}, result['meta'])
  587. def test_port_export_so_number_error_uses_business_label(self):
  588. result = self.presenter.present(
  589. 'export_out_of_province_port_data',
  590. {
  591. 'code': 'MCP_1401',
  592. 'msg': 'so_numbers must be an array',
  593. 'data': {'so_numbers': 'bad'},
  594. 'meta': {'request_id': 'rq_so_error'},
  595. },
  596. )
  597. self.assertTrue(result['is_error'])
  598. self.assertEqual('SO号参数不正确', result['structured_content']['message'])
  599. self.assertNotIn('so_numbers', json.dumps(result, ensure_ascii=False))
  600. def test_pallet_export_container_code_error_uses_business_label(self):
  601. result = self.presenter.present(
  602. 'export_pallet_data',
  603. {
  604. 'code': 'MCP_1401',
  605. 'msg': 'container_codes must be an array',
  606. 'data': {'container_codes': 'bad'},
  607. 'meta': {'request_id': 'rq_container_error'},
  608. },
  609. )
  610. self.assertTrue(result['is_error'])
  611. self.assertEqual('柜号参数不正确', result['structured_content']['message'])
  612. self.assertNotIn('container_codes', json.dumps(result, ensure_ascii=False))
  613. self.assertEqual({'request_id': 'rq_container_error'}, result['meta'])
  614. def test_pallet_export_bl_number_error_uses_business_label(self):
  615. result = self.presenter.present(
  616. 'export_pallet_data',
  617. {
  618. 'code': 'MCP_1401',
  619. 'msg': 'bl_numbers must be an array',
  620. 'data': {'bl_numbers': 'bad'},
  621. 'meta': {'request_id': 'rq_bl_error'},
  622. },
  623. )
  624. self.assertTrue(result['is_error'])
  625. self.assertEqual('提单号参数不正确', result['structured_content']['message'])
  626. self.assertNotIn('bl_numbers', json.dumps(result, ensure_ascii=False))
  627. self.assertEqual({'request_id': 'rq_bl_error'}, result['meta'])
  628. def test_pallet_export_inbound_time_start_error_uses_business_label(self):
  629. result = self.presenter.present(
  630. 'export_pallet_data',
  631. {
  632. 'code': 'MCP_1401',
  633. 'msg': 'inbound_time_start is required',
  634. 'data': {'inbound_time_start': ''},
  635. 'meta': {'request_id': 'rq_time_start_error'},
  636. },
  637. )
  638. self.assertTrue(result['is_error'])
  639. self.assertEqual(
  640. '海外仓入库时间开始参数不正确',
  641. result['structured_content']['message'],
  642. )
  643. self.assertNotIn('inbound_time_start', json.dumps(result, ensure_ascii=False))
  644. self.assertEqual({'request_id': 'rq_time_start_error'}, result['meta'])
  645. def test_pallet_export_inbound_time_end_error_uses_business_label(self):
  646. result = self.presenter.present(
  647. 'export_pallet_data',
  648. {
  649. 'code': 'MCP_1401',
  650. 'msg': 'inbound_time_end is required',
  651. 'data': {'inbound_time_end': ''},
  652. 'meta': {'request_id': 'rq_time_end_error'},
  653. },
  654. )
  655. self.assertTrue(result['is_error'])
  656. self.assertEqual(
  657. '海外仓入库时间结束参数不正确',
  658. result['structured_content']['message'],
  659. )
  660. self.assertNotIn('inbound_time_end', json.dumps(result, ensure_ascii=False))
  661. self.assertEqual({'request_id': 'rq_time_end_error'}, result['meta'])
  662. def test_system_error_hides_backend_message_and_data(self):
  663. result = self.presenter.present(
  664. 'query_order_exact',
  665. {
  666. 'code': 'MCP_9001',
  667. 'msg': 'SQLSTATE table st_order order_number failed',
  668. 'data': {'sql': 'select * from st_order'},
  669. },
  670. )
  671. serialized = json.dumps(result, ensure_ascii=False)
  672. self.assertIn('工具调用失败,请稍后重试', serialized)
  673. self.assertNotIn('SQLSTATE', serialized)
  674. self.assertNotIn('st_order', serialized)
  675. self.assertNotIn('order_number', serialized)
  676. def test_new_business_error_codes_have_stable_messages_and_are_not_retryable(self):
  677. cases = {
  678. 'MCP_1103': '员工账号不可用,请联系管理员',
  679. 'MCP_1104': '身份信息已失效,请重新登录或重新生成设备配置',
  680. 'MCP_1501': '目标数据不可用',
  681. 'MCP_1502': '结果过多,请缩小查询范围',
  682. 'MCP_1601': '没有可导出的数据',
  683. }
  684. for code, message in cases.items():
  685. with self.subTest(code=code):
  686. result = self.presenter.present(
  687. 'query_order_exact',
  688. {'code': code, 'msg': 'internal detail', 'data': []},
  689. )
  690. self.assertEqual(code, result['structured_content']['code'])
  691. self.assertEqual(message, result['structured_content']['message'])
  692. self.assertFalse(result['structured_content']['retryable'])
  693. def test_unknown_business_error_code_is_normalized_to_system_error(self):
  694. with self.assertLogs('services.output_presenter', level='WARNING') as logs:
  695. result = self.presenter.present(
  696. 'query_order_exact',
  697. {
  698. 'code': 'MCP_7777',
  699. 'msg': 'secret backend detail',
  700. 'data': [],
  701. 'meta': {'request_id': 'rq_unknown_code'},
  702. },
  703. )
  704. self.assertEqual('MCP_9001', result['structured_content']['code'])
  705. self.assertEqual('工具调用失败,请稍后重试', result['structured_content']['message'])
  706. self.assertTrue(result['structured_content']['retryable'])
  707. self.assertNotIn('secret', json.dumps(result, ensure_ascii=False))
  708. record = logs.records[0]
  709. self.assertEqual('rq_unknown_code', record.request_id)
  710. self.assertEqual('query_order_exact', record.tool_code)
  711. self.assertEqual('MCP_7777', record.backend_code)
  712. self.assertEqual('MCP_9001', record.response_code)
  713. self.assertEqual('UNEXPECTED_EXCEPTION', record.diagnostic_reason)
  714. def test_unknown_tool_and_malformed_success_fail_closed(self):
  715. unknown = self.presenter.present(
  716. 'future_tool',
  717. {'code': 'MCP_0000', 'data': {'secret_field': 'secret'}},
  718. )
  719. malformed = self.presenter.present(
  720. 'query_track',
  721. {'code': 'MCP_0000', 'data': {'records': []}},
  722. )
  723. for result in (unknown, malformed):
  724. self.assertTrue(result['is_error'])
  725. self.assertEqual('工具返回格式异常', result['structured_content']['message'])
  726. self.assertNotIn('secret', json.dumps(result, ensure_ascii=False))
  727. def test_present_exception_maps_value_error_and_hides_unknown_exception(self):
  728. parameter = self.presenter.present_exception(
  729. 'query_track',
  730. ValueError('order_number is required'),
  731. )
  732. system = self.presenter.present_exception(
  733. 'query_track',
  734. RuntimeError('SQL password leaked'),
  735. )
  736. self.assertEqual('订单号参数不正确', parameter['structured_content']['message'])
  737. self.assertEqual('工具调用失败,请稍后重试', system['structured_content']['message'])
  738. self.assertNotIn('password', json.dumps(system, ensure_ascii=False))
  739. def test_present_exception_handles_device_disabled_and_unknown_tool(self):
  740. device = self.presenter.present_exception(
  741. 'query_track',
  742. RuntimeError('这台设备的 Workbuddy 配置已失效,请重新生成配置。'),
  743. )
  744. disabled = self.presenter.present_exception(
  745. 'query_track',
  746. RuntimeError('tool disabled: query_track'),
  747. )
  748. unknown = self.presenter.present_exception(
  749. 'future_tool',
  750. RuntimeError('secret error'),
  751. )
  752. self.assertIn('Workbuddy', device['structured_content']['message'])
  753. self.assertEqual('MCP_1202', disabled['structured_content']['code'])
  754. self.assertEqual('工具返回格式异常', unknown['structured_content']['message'])
  755. def test_invalid_payload_types_and_generic_errors_fail_safely(self):
  756. cases = (
  757. self.presenter.present('query_track', 'invalid'),
  758. self.presenter.present('query_track', {'code': 'MCP_0000', 'data': []}),
  759. self.presenter.present('query_track', {'code': '', 'msg': 'secret'}),
  760. self.presenter.present(
  761. 'query_track',
  762. {'code': 'MCP_7777', 'msg': 'secret backend error'},
  763. ),
  764. self.presenter.present(
  765. 'query_track',
  766. {'code': 'MCP_1301', 'msg': 'secret permission detail'},
  767. ),
  768. )
  769. for result in cases:
  770. self.assertTrue(result['is_error'])
  771. self.assertNotIn('secret', json.dumps(result, ensure_ascii=False))
  772. def test_malformed_table_parts_fail_closed(self):
  773. base = {
  774. 'code': 'MCP_0000',
  775. 'data': {
  776. 'columns': [{'key': 'status', 'name': '状态'}],
  777. 'records': [],
  778. },
  779. }
  780. bad_data = (
  781. {'columns': [], 'records': []},
  782. {'columns': [{'key': 'status', 'name': '状态'}], 'records': None},
  783. {'columns': ['status'], 'records': []},
  784. {'columns': [{'key': None, 'name': '状态'}], 'records': []},
  785. {'columns': [{'key': ' ', 'name': '状态'}], 'records': []},
  786. {'columns': [{'key': 'status', 'name': None}], 'records': []},
  787. {'columns': [{'key': 'status', 'name': ' '}], 'records': []},
  788. {'columns': [{'key': 'status', 'name': '状态'}], 'records': ['bad']},
  789. )
  790. for data in bad_data:
  791. with self.subTest(data=data):
  792. payload = dict(base)
  793. payload['data'] = data
  794. self.assertTrue(self.presenter.present('query_track', payload)['is_error'])
  795. def test_malformed_options_and_exports_fail_closed(self):
  796. cases = (
  797. self.presenter.present(
  798. 'list_order_filter_options',
  799. {'code': 'MCP_0000', 'data': {'records': None}},
  800. ),
  801. self.presenter.present(
  802. 'list_order_filter_options',
  803. {'code': 'MCP_0000', 'data': {'records': ['bad']}},
  804. ),
  805. self.presenter.present(
  806. 'export_pending_outbound_orders',
  807. {
  808. 'code': 'MCP_0000',
  809. 'data': {
  810. 'task_ref': '',
  811. 'status': 'queued',
  812. 'retry_after_seconds': 10,
  813. },
  814. },
  815. ),
  816. self.presenter.present(
  817. 'export_pending_outbound_orders',
  818. {
  819. 'code': 'MCP_0000',
  820. 'data': {
  821. 'task_ref': 'mexp_abc',
  822. 'status': 'queued',
  823. 'retry_after_seconds': 10,
  824. 'extra': True,
  825. },
  826. },
  827. ),
  828. self.presenter.present(
  829. 'export_pending_outbound_orders',
  830. {
  831. 'code': 'MCP_0000',
  832. 'data': {
  833. 'task_ref': 'mexp_abc',
  834. 'status': 'queued',
  835. 'retry_after_seconds': 0,
  836. },
  837. },
  838. ),
  839. )
  840. self.assertTrue(all(result['is_error'] for result in cases))
  841. def test_optional_text_meta_and_nested_values_cover_safe_boundaries(self):
  842. result = self.presenter.present(
  843. 'query_track',
  844. {
  845. 'code': 'MCP_0000',
  846. 'data': {
  847. 'summary': None,
  848. 'columns': [
  849. {'key': 'status', 'name': '状态', 'description': ''},
  850. {'key': 'content', 'name': '详情', 'description': 123},
  851. ],
  852. 'records': [{'status': {'name': '已发货'}, 'content': ['A']}],
  853. 'tips': ['', None, '有效提示'],
  854. },
  855. 'meta': {'request_id': ' ', 'page': 1},
  856. },
  857. )
  858. self.assertFalse(result['is_error'])
  859. self.assertEqual({}, result['meta'])
  860. self.assertIn('{"name": "已发货"}', result['text'])
  861. self.assertIn('["A"]', result['text'])
  862. self.assertEqual(['有效提示'], result['structured_content']['tips'])
  863. no_meta = self.presenter.present(
  864. 'list_order_filter_options',
  865. {'code': 'MCP_0000', 'data': {'records': []}, 'meta': None},
  866. )
  867. self.assertNotIn('pagination', no_meta['structured_content'])
  868. def test_parameter_error_without_known_field_is_generic(self):
  869. result = self.presenter.present(
  870. 'query_track',
  871. {'code': 'MCP_1401', 'msg': 'invalid request'},
  872. )
  873. self.assertEqual(
  874. '工具参数不正确,请检查后重试',
  875. result['structured_content']['message'],
  876. )
  877. def test_query_order_is_explicitly_not_presented(self):
  878. self.assertFalse(self.presenter.handles('query_order'))
  879. self.assertTrue(self.presenter.handles('query_order_exact'))
  880. def test_unhashable_tool_names_fail_closed(self):
  881. for tool_name in ([], {}):
  882. with self.subTest(tool_name=tool_name):
  883. self.assertFalse(self.presenter.handles(tool_name))
  884. result = self.presenter.present_exception(
  885. tool_name,
  886. RuntimeError('secret backend error'),
  887. )
  888. self.assertTrue(result['is_error'])
  889. self.assertEqual(
  890. '工具返回格式异常',
  891. result['structured_content']['message'],
  892. )
  893. def test_safe_tool_descriptions_require_business_labels_only(self):
  894. safe_tools = (
  895. QueryOrderExactTool(),
  896. QueryTrackTool(),
  897. ListOrderFilterOptionsTool(),
  898. ListPendingOutboundExportFilterOptionsTool(),
  899. ExportPendingOutboundOrdersTool(),
  900. ExportOutOfProvincePortDataTool(),
  901. )
  902. for tool in safe_tools:
  903. with self.subTest(tool=tool.name):
  904. self.assertIn('不得展示内部参数名', tool.metadata()['description'])
  905. self.assertNotIn('不得展示内部参数名', QueryOrderTool().metadata()['description'])
  906. def test_presented_order_and_option_values_can_feed_follow_up_tools(self):
  907. class RecordingClient:
  908. def __init__(self):
  909. self.calls = []
  910. def call_tool(self, tool_code, route_path, payload, request_id):
  911. self.calls.append((tool_code, payload))
  912. return {'code': 'MCP_0000'}
  913. order_result = self.presenter.present(
  914. 'query_order_exact',
  915. {
  916. 'code': 'MCP_0000',
  917. 'data': {
  918. 'columns': [{'key': 'order_number', 'name': '订单号'}],
  919. 'records': [{'order_number': 'SO-FOLLOW-UP'}],
  920. },
  921. },
  922. )
  923. option_result = self.presenter.present(
  924. 'list_order_filter_options',
  925. {
  926. 'code': 'MCP_0000',
  927. 'data': {
  928. 'records': [{'value': 901, 'label': '客户甲', 'code': 'C901'}],
  929. },
  930. },
  931. )
  932. client = RecordingClient()
  933. QueryTrackTool(client).call(
  934. order_number=order_result['structured_content']['rows'][0][0],
  935. )
  936. QueryOrderExactTool(client).call(
  937. customer_ids=[option_result['structured_content']['rows'][0][0]],
  938. )
  939. self.assertEqual(
  940. ('query_track', {'page': 1, 'limit': 5, 'order_number': 'SO-FOLLOW-UP'}),
  941. client.calls[0],
  942. )
  943. self.assertEqual([901], client.calls[1][1]['customer_ids'])
  944. if __name__ == '__main__':
  945. unittest.main()