test_output_presenter.py 37 KB

123456789101112131415161718192021222324252627282930313233343536373839404142434445464748495051525354555657585960616263646566676869707172737475767778798081828384858687888990919293949596979899100101102103104105106107108109110111112113114115116117118119120121122123124125126127128129130131132133134135136137138139140141142143144145146147148149150151152153154155156157158159160161162163164165166167168169170171172173174175176177178179180181182183184185186187188189190191192193194195196197198199200201202203204205206207208209210211212213214215216217218219220221222223224225226227228229230231232233234235236237238239240241242243244245246247248249250251252253254255256257258259260261262263264265266267268269270271272273274275276277278279280281282283284285286287288289290291292293294295296297298299300301302303304305306307308309310311312313314315316317318319320321322323324325326327328329330331332333334335336337338339340341342343344345346347348349350351352353354355356357358359360361362363364365366367368369370371372373374375376377378379380381382383384385386387388389390391392393394395396397398399400401402403404405406407408409410411412413414415416417418419420421422423424425426427428429430431432433434435436437438439440441442443444445446447448449450451452453454455456457458459460461462463464465466467468469470471472473474475476477478479480481482483484485486487488489490491492493494495496497498499500501502503504505506507508509510511512513514515516517518519520521522523524525526527528529530531532533534535536537538539540541542543544545546547548549550551552553554555556557558559560561562563564565566567568569570571572573574575576577578579580581582583584585586587588589590591592593594595596597598599600601602603604605606607608609610611612613614615616617618619620621622623624625626627628629630631632633634635636637638639640641642643644645646647648649650651652653654655656657658659660661662663664665666667668669670671672673674675676677678679680681682683684685686687688689690691692693694695696697698699700701702703704705706707708709710711712713714715716717718719720721722723724725726727728729730731732733734735736737738739740741742743744745746747748749750751752753754755756757758759760761762763764765766767768769770771772773774775776777778779780781782783784785786787788789790791792793794795796797798799800801802803804805806807808809810811812813814815816817818819820821822823824825826827828829830831832833834835836837838839840841842843844845846847848849850851852853854855856857858859860861862863864865866867868869870871872873874875876877878879880881882883884885886887888889890891892893894895896897898899900901902903904905906907908909910911912913914915916917918919920921922923924925926927928929930931932933934935936937938939940941942943944945946947948949950951952953954955956
  1. import json
  2. import unittest
  3. from services.output_presenter import OutputPresenter
  4. from tools.export_out_of_province_port_data import ExportOutOfProvincePortDataTool
  5. from tools.export_pending_outbound_orders import ExportPendingOutboundOrdersTool
  6. from tools.list_order_filter_options import ListOrderFilterOptionsTool
  7. from tools.list_customer_filter_options import ListCustomerFilterOptionsTool
  8. from tools.list_pending_outbound_export_filter_options import (
  9. ListPendingOutboundExportFilterOptionsTool,
  10. )
  11. from tools.query_order import QueryOrderTool
  12. from tools.query_order_exact import QueryOrderExactTool
  13. from tools.query_track import QueryTrackTool
  14. from tools.query_customer_list import QueryCustomerListTool
  15. class OutputPresenterTest(unittest.TestCase):
  16. def setUp(self):
  17. self.presenter = OutputPresenter()
  18. def test_customer_list_uses_fixed_17_column_safe_table(self):
  19. keys = [
  20. 'customer_name', 'customer_code', 'create_time', 'business_type',
  21. 'customer_attribute', 'customer_source', 'first_inbound_date',
  22. 'last_inbound_date', 'active_status', 'contract_status',
  23. 'contract_validity', 'credit_limit', 'currency_code',
  24. 'billing_modes', 'sales_name', 'merchandiser_name',
  25. 'department_name',
  26. ]
  27. result = self.presenter.present('query_customer_list', {
  28. 'code': 'MCP_0000',
  29. 'data': {
  30. 'summary': '当前页返回1个客户',
  31. 'columns': [{'key': key, 'name': '不可信名称'} for key in keys],
  32. 'records': [dict(
  33. (key, [
  34. {'business_type': '头程业务', 'settlement_mode': '月结'},
  35. {'business_type': '转运业务', 'settlement_mode': '票结'},
  36. ] if key == 'billing_modes' else '值{0}'.format(index))
  37. for index, key in enumerate(keys)
  38. )],
  39. 'tips': [],
  40. },
  41. 'meta': {
  42. 'page': 1, 'limit': 20, 'has_more': False,
  43. 'request_id': 'rq_customer',
  44. },
  45. })
  46. self.assertFalse(result['is_error'])
  47. self.assertEqual(17, len(result['structured_content']['headers']))
  48. self.assertEqual('客户名称', result['structured_content']['headers'][0]['label'])
  49. self.assertEqual('事业部', result['structured_content']['headers'][-1]['label'])
  50. self.assertEqual([
  51. {'业务类型': '头程业务', '结算模式': '月结'},
  52. {'业务类型': '转运业务', '结算模式': '票结'},
  53. ], result['structured_content']['rows'][0][13])
  54. self.assertEqual({
  55. 'mode': 'complete',
  56. 'allow_summary': False,
  57. 'allow_omit_records': False,
  58. 'allow_omit_empty_fields': False,
  59. 'allow_rename_fields': False,
  60. 'preserve_record_order': True,
  61. 'required_field_count': 17,
  62. 'returned_record_count': 1,
  63. 'required_value_count': 17,
  64. 'instruction': '最终回复必须逐条展示全部记录及全部17个字段,不得摘要、省略或改写',
  65. }, result['structured_content']['display_rules'])
  66. self.assertIn('完整客户数据,禁止摘要、合并、隐藏字段或省略空字段。', result['text'])
  67. self.assertIn('本页记录数:1;每条字段数:17;应展示字段值总数:17。', result['text'])
  68. self.assertIn('展示完整性校验:已提供1条客户的全部17个字段。', result['text'])
  69. serialized = json.dumps(result, ensure_ascii=False)
  70. self.assertNotIn('customer_name', serialized)
  71. self.assertNotIn('不可信名称', serialized)
  72. def test_customer_list_rejects_malformed_structured_billing_modes(self):
  73. keys = list(self.presenter.TABLE_COLUMNS['query_customer_list'])
  74. for billing_modes in (
  75. '头程业务:月结',
  76. [{'business_type': '头程业务'}],
  77. [{'business_type': '头程业务', 'settlement_mode': '月结', 'id': 1}],
  78. [{'business_type': '', 'settlement_mode': '月结'}],
  79. ):
  80. with self.subTest(billing_modes=billing_modes):
  81. record = dict((key, '') for key in keys)
  82. record['billing_modes'] = billing_modes
  83. result = self.presenter.present('query_customer_list', {
  84. 'code': 'MCP_0000',
  85. 'data': {
  86. 'summary': '',
  87. 'columns': [{'key': key, 'name': key} for key in keys],
  88. 'records': [record],
  89. 'tips': [],
  90. },
  91. 'meta': {'page': 1, 'limit': 20, 'has_more': False},
  92. })
  93. self.assertTrue(result['is_error'])
  94. record = dict((key, '') for key in keys)
  95. record['billing_modes'] = []
  96. record['customer_name'] = ['不允许的嵌套值']
  97. result = self.presenter.present('query_customer_list', {
  98. 'code': 'MCP_0000',
  99. 'data': {
  100. 'summary': '',
  101. 'columns': [{'key': key, 'name': key} for key in keys],
  102. 'records': [record],
  103. 'tips': [],
  104. },
  105. 'meta': {'page': 1, 'limit': 20, 'has_more': False},
  106. })
  107. self.assertTrue(result['is_error'])
  108. def test_customer_list_fails_closed_on_incomplete_columns_or_bad_meta(self):
  109. base = {
  110. 'code': 'MCP_0000',
  111. 'data': {
  112. 'summary': '',
  113. 'columns': [{'key': 'customer_name', 'name': '客户名称'}],
  114. 'records': [], 'tips': [],
  115. },
  116. 'meta': {'page': 1, 'limit': 20, 'has_more': False},
  117. }
  118. self.assertTrue(self.presenter.present('query_customer_list', base)['is_error'])
  119. keys = list(self.presenter.TABLE_COLUMNS['query_customer_list'])
  120. base['data']['columns'] = [{'key': key, 'name': key} for key in keys]
  121. base['meta']['has_more'] = 'false'
  122. self.assertTrue(self.presenter.present('query_customer_list', base)['is_error'])
  123. def test_customer_list_rejects_record_with_internal_field(self):
  124. keys = list(self.presenter.TABLE_COLUMNS['query_customer_list'])
  125. record = dict((key, '') for key in keys)
  126. record['customer_id'] = 9
  127. result = self.presenter.present('query_customer_list', {
  128. 'code': 'MCP_0000',
  129. 'data': {
  130. 'summary': '', 'columns': [{'key': key, 'name': key} for key in keys],
  131. 'records': [record], 'tips': [],
  132. },
  133. 'meta': {'page': 1, 'limit': 20, 'has_more': False},
  134. })
  135. self.assertTrue(result['is_error'])
  136. def test_customer_options_use_safe_shape_and_reject_unknown_fields(self):
  137. result = self.presenter.present('list_customer_filter_options', {
  138. 'code': 'MCP_0000',
  139. 'data': {'records': [{'value': 7, 'label': '客户甲-C001', 'code': 'C001'}]},
  140. 'meta': {'page': 1, 'limit': 20, 'has_more': False},
  141. })
  142. self.assertFalse(result['is_error'])
  143. self.assertEqual([[7, '客户甲-C001', 'C001']], result['structured_content']['rows'])
  144. malformed = self.presenter.present('list_customer_filter_options', {
  145. 'code': 'MCP_0000',
  146. 'data': {'records': [{
  147. 'value': 7, 'label': '客户甲', 'code': 'C001', 'admin_id': 99,
  148. }]},
  149. 'meta': {'page': 1, 'limit': 20, 'has_more': False},
  150. })
  151. self.assertTrue(malformed['is_error'])
  152. self.assertNotIn('99', malformed['text'])
  153. def test_customer_options_reject_malformed_records_and_pagination(self):
  154. def present(records, meta):
  155. return self.presenter.present('list_customer_filter_options', {
  156. 'code': 'MCP_0000', 'data': {'records': records}, 'meta': meta,
  157. })
  158. good_meta = {'page': 1, 'limit': 20, 'has_more': False}
  159. bad_records = [
  160. 'record',
  161. {'value': 1, 'label': '客户甲'},
  162. {'value': True, 'label': '客户甲', 'code': ''},
  163. {'value': '1', 'label': '客户甲', 'code': ''},
  164. {'value': 0, 'label': '客户甲', 'code': ''},
  165. {'value': 1, 'label': 2, 'code': ''},
  166. {'value': 1, 'label': ' ', 'code': ''},
  167. {'value': 1, 'label': '客户甲', 'code': 3},
  168. ]
  169. for record in bad_records:
  170. with self.subTest(record=record):
  171. self.assertTrue(present([record], good_meta)['is_error'])
  172. self.assertTrue(present('records', good_meta)['is_error'])
  173. self.assertTrue(self.presenter.present('list_customer_filter_options', {
  174. 'code': 'MCP_0000', 'data': {'records': [], 'extra': 1}, 'meta': good_meta,
  175. })['is_error'])
  176. bad_meta = [
  177. None, {},
  178. {'page': True, 'limit': 20, 'has_more': False},
  179. {'page': '1', 'limit': 20, 'has_more': False},
  180. {'page': 0, 'limit': 20, 'has_more': False},
  181. {'page': 1, 'limit': True, 'has_more': False},
  182. {'page': 1, 'limit': '20', 'has_more': False},
  183. {'page': 1, 'limit': 0, 'has_more': False},
  184. {'page': 1, 'limit': 101, 'has_more': False},
  185. {'page': 1, 'limit': 20, 'has_more': 'false'},
  186. ]
  187. for meta in bad_meta:
  188. with self.subTest(meta=meta):
  189. self.assertTrue(present([], meta)['is_error'])
  190. def test_customer_tools_are_safe_and_total_is_16(self):
  191. self.assertTrue(self.presenter.handles(QueryCustomerListTool.name))
  192. self.assertTrue(self.presenter.handles(ListCustomerFilterOptionsTool.name))
  193. self.assertEqual(16, len(self.presenter.SAFE_TOOLS))
  194. def test_exact_order_uses_labels_and_drops_internal_fields(self):
  195. result = self.presenter.present(
  196. 'query_order_exact',
  197. {
  198. 'code': 'MCP_0000',
  199. 'data': {
  200. 'summary': '当前页返回 1 条订单',
  201. 'columns': [
  202. {'key': 'order_number', 'name': '订单号'},
  203. {
  204. 'key': 'tracking_number',
  205. 'name': '快递单号',
  206. 'description': '承运商跟踪号码',
  207. },
  208. ],
  209. 'records': [{
  210. 'order_number': 'SO001',
  211. 'tracking_number': 'TN001',
  212. 'order_id': 99,
  213. 'time_zone': '8.00',
  214. }],
  215. 'tips': [],
  216. },
  217. 'meta': {
  218. 'page': 1,
  219. 'limit': 20,
  220. 'has_more': False,
  221. 'request_id': 'rq_exact',
  222. },
  223. },
  224. )
  225. self.assertFalse(result['is_error'])
  226. self.assertEqual(
  227. [
  228. {'label': '订单号'},
  229. {'label': '快递单号', 'description': '承运商跟踪号码'},
  230. ],
  231. result['structured_content']['headers'],
  232. )
  233. self.assertEqual(
  234. [['SO001', 'TN001']],
  235. result['structured_content']['rows'],
  236. )
  237. self.assertEqual(
  238. {'page': 1, 'limit': 20, 'has_more': False},
  239. result['structured_content']['pagination'],
  240. )
  241. self.assertEqual({'request_id': 'rq_exact'}, result['meta'])
  242. serialized = json.dumps(result, ensure_ascii=False)
  243. self.assertNotIn('order_number', serialized)
  244. self.assertNotIn('tracking_number', serialized)
  245. self.assertNotIn('order_id', serialized)
  246. self.assertNotIn('time_zone', serialized)
  247. self.assertIn('订单号', result['text'])
  248. self.assertIn('SO001', result['text'])
  249. def test_table_tools_reject_unknown_backend_columns(self):
  250. for tool_name in (
  251. 'query_order_exact',
  252. 'query_track',
  253. 'query_customs_declaration_files',
  254. ):
  255. with self.subTest(tool_name=tool_name):
  256. result = self.presenter.present(
  257. tool_name,
  258. {
  259. 'code': 'MCP_0000',
  260. 'data': {
  261. 'columns': [
  262. {'key': 'order_id', 'name': '内部订单ID'},
  263. ],
  264. 'records': [{'order_id': 99}],
  265. },
  266. },
  267. )
  268. self.assertTrue(result['is_error'])
  269. self.assertEqual(
  270. '工具返回格式异常',
  271. result['structured_content']['message'],
  272. )
  273. self.assertNotIn('99', result['text'])
  274. def test_table_tools_use_fixed_labels_instead_of_backend_labels(self):
  275. result = self.presenter.present(
  276. 'query_customs_declaration_files',
  277. {
  278. 'code': 'MCP_0000',
  279. 'data': {
  280. 'columns': [
  281. {'key': 'order_number', 'name': '内部名称'},
  282. ],
  283. 'records': [{'order_number': 'ORD001'}],
  284. },
  285. },
  286. )
  287. self.assertFalse(result['is_error'])
  288. self.assertEqual(
  289. [{'label': '订单号'}],
  290. result['structured_content']['headers'],
  291. )
  292. self.assertNotIn('内部名称', result['text'])
  293. def test_table_tool_without_column_definition_fails_closed(self):
  294. definition = self.presenter.TABLE_COLUMNS.pop('query_track')
  295. try:
  296. result = self.presenter.present(
  297. 'query_track',
  298. {
  299. 'code': 'MCP_0000',
  300. 'data': {
  301. 'columns': [{'key': 'status', 'name': '轨迹节点'}],
  302. 'records': [],
  303. },
  304. },
  305. )
  306. finally:
  307. self.presenter.TABLE_COLUMNS['query_track'] = definition
  308. self.assertTrue(result['is_error'])
  309. self.assertEqual(
  310. '工具返回格式异常',
  311. result['structured_content']['message'],
  312. )
  313. def test_table_missing_value_is_empty_and_fixed_labels_are_used(self):
  314. result = self.presenter.present(
  315. 'query_track',
  316. {
  317. 'code': '0',
  318. 'data': {
  319. 'columns': [
  320. {'key': 'status', 'name': '状态'},
  321. {'key': 'content', 'name': '状态'},
  322. ],
  323. 'records': [{'status': '已发货'}],
  324. 'tips': ['仅展示已有轨迹'],
  325. },
  326. 'meta': {'request_id': 'rq_track'},
  327. },
  328. )
  329. self.assertEqual(
  330. [
  331. {
  332. 'label': '轨迹节点',
  333. 'description': '轨迹状态,如:开始集港、离港放行、清关、配送等',
  334. },
  335. {'label': '轨迹内容', 'description': '详细描述'},
  336. ],
  337. result['structured_content']['headers'],
  338. )
  339. self.assertEqual([['已发货', '']], result['structured_content']['rows'])
  340. self.assertEqual(['仅展示已有轨迹'], result['structured_content']['tips'])
  341. def test_empty_table_keeps_safe_headers_and_tips(self):
  342. result = self.presenter.present(
  343. 'query_track',
  344. {
  345. 'code': 'MCP_0000',
  346. 'data': {
  347. 'columns': [{'key': 'status', 'name': '轨迹节点'}],
  348. 'records': [],
  349. 'tips': ['未查询到轨迹信息'],
  350. },
  351. 'meta': {'page': 1, 'limit': 5, 'total': 0},
  352. },
  353. )
  354. self.assertEqual(
  355. [{
  356. 'label': '轨迹节点',
  357. 'description': '轨迹状态,如:开始集港、离港放行、清关、配送等',
  358. }],
  359. result['structured_content']['headers'],
  360. )
  361. self.assertEqual([], result['structured_content']['rows'])
  362. self.assertIn('未查询到轨迹信息', result['text'])
  363. without_tips = self.presenter.present(
  364. 'query_track',
  365. {
  366. 'code': 'MCP_0000',
  367. 'data': {
  368. 'columns': [{'key': 'status', 'name': '轨迹节点'}],
  369. 'records': [],
  370. 'tips': 'not-a-list',
  371. },
  372. },
  373. )
  374. self.assertNotIn('tips', without_tips['structured_content'])
  375. def test_filter_options_preserve_values_for_follow_up_calls(self):
  376. result = self.presenter.present(
  377. 'list_order_filter_options',
  378. {
  379. 'code': 'MCP_0000',
  380. 'data': {
  381. 'records': [
  382. {'value': 101, 'label': '客户甲', 'code': 'CUS-A'},
  383. {'value': -1, 'label': '客户仓', 'code': '-1'},
  384. ],
  385. },
  386. 'meta': {'page': 2, 'limit': 20, 'has_more': True},
  387. },
  388. )
  389. self.assertEqual(
  390. [[101, '客户甲', 'CUS-A'], [-1, '客户仓', '-1']],
  391. result['structured_content']['rows'],
  392. )
  393. self.assertEqual(
  394. ['可传值', '显示名称', '业务编码'],
  395. [item['label'] for item in result['structured_content']['headers']],
  396. )
  397. self.assertNotIn('"value"', json.dumps(result, ensure_ascii=False))
  398. def test_pending_filter_options_use_same_safe_shape(self):
  399. result = self.presenter.present(
  400. 'list_pending_outbound_export_filter_options',
  401. {
  402. 'code': 'MCP_0000',
  403. 'data': {'records': [{'value': 'US', 'label': '美国', 'code': 'US'}]},
  404. 'meta': {},
  405. },
  406. )
  407. self.assertEqual([['US', '美国', 'US']], result['structured_content']['rows'])
  408. def test_export_submission_returns_only_safe_queued_task(self):
  409. for tool_name in (
  410. 'export_pending_outbound_orders',
  411. 'export_out_of_province_port_data',
  412. ):
  413. with self.subTest(tool_name=tool_name):
  414. result = self.presenter.present(
  415. tool_name,
  416. {
  417. 'code': 'MCP_0000',
  418. 'data': {
  419. 'task_ref': 'mexp_abc',
  420. 'status': 'queued',
  421. 'retry_after_seconds': 10,
  422. },
  423. 'meta': {'request_id': 'rq_export'},
  424. },
  425. )
  426. self.assertEqual(
  427. {
  428. 'task_ref': 'mexp_abc',
  429. 'status': 'queued',
  430. 'retry_after_seconds': 10,
  431. },
  432. result['structured_content']['task'],
  433. )
  434. self.assertNotIn('file_url', json.dumps(result, ensure_ascii=False))
  435. def test_export_task_query_presents_all_known_states(self):
  436. queued = self.presenter.present(
  437. 'query_export_task',
  438. {
  439. 'code': 'MCP_0000',
  440. 'data': {
  441. 'task_ref': 'mexp_abc',
  442. 'status': 'queued',
  443. 'retry_after_seconds': 10,
  444. },
  445. },
  446. )
  447. running = self.presenter.present(
  448. 'query_export_task',
  449. {
  450. 'code': 'MCP_0000',
  451. 'data': {
  452. 'task_ref': 'mexp_abc',
  453. 'status': 'running',
  454. 'retry_after_seconds': 10,
  455. },
  456. },
  457. )
  458. completed = self.presenter.present(
  459. 'query_export_task',
  460. {
  461. 'code': 'MCP_0000',
  462. 'data': {
  463. 'task_ref': 'mexp_abc',
  464. 'status': 'completed',
  465. 'files': [{
  466. 'label': 'port.zip',
  467. 'url': 'https://files.test/port.zip',
  468. }],
  469. },
  470. },
  471. )
  472. failed = self.presenter.present(
  473. 'query_export_task',
  474. {
  475. 'code': 'MCP_0000',
  476. 'data': {'task_ref': 'mexp_abc', 'status': 'failed'},
  477. },
  478. )
  479. self.assertEqual('queued', queued['structured_content']['task']['status'])
  480. self.assertEqual('running', running['structured_content']['task']['status'])
  481. self.assertEqual(
  482. 'https://files.test/port.zip',
  483. completed['structured_content']['files'][0]['url'],
  484. )
  485. self.assertEqual('failed', failed['structured_content']['task']['status'])
  486. def test_export_task_unknown_or_malformed_states_fail_closed(self):
  487. cases = (
  488. {
  489. 'task_ref': 123,
  490. 'status': 'queued',
  491. 'retry_after_seconds': 10,
  492. },
  493. {'task_ref': 'mexp_abc', 'status': 'unknown'},
  494. {'task_ref': 'mexp_abc', 'status': 'queued'},
  495. {
  496. 'task_ref': 'mexp_abc',
  497. 'status': 'queued',
  498. 'retry_after_seconds': 0,
  499. },
  500. {
  501. 'task_ref': 'mexp_abc',
  502. 'status': 'running',
  503. 'retry_after_seconds': 10,
  504. 'files': [],
  505. },
  506. {
  507. 'task_ref': 'mexp_abc',
  508. 'status': 'completed',
  509. 'files': None,
  510. },
  511. {
  512. 'task_ref': 'mexp_abc',
  513. 'status': 'completed',
  514. 'files': ['bad'],
  515. },
  516. {
  517. 'task_ref': 'mexp_abc',
  518. 'status': 'completed',
  519. 'files': [{'label': 'bad', 'url': None}],
  520. },
  521. {
  522. 'task_ref': 'mexp_abc',
  523. 'status': 'completed',
  524. 'files': [{'label': 'bad', 'url': 'javascript:alert(1)'}],
  525. },
  526. {
  527. 'task_ref': 'mexp_abc',
  528. 'status': 'completed',
  529. 'files': [],
  530. 'extra': True,
  531. },
  532. {
  533. 'task_ref': 'mexp_abc',
  534. 'status': 'failed',
  535. 'remark': 'secret',
  536. },
  537. )
  538. for data in cases:
  539. with self.subTest(data=data):
  540. result = self.presenter.present(
  541. 'query_export_task',
  542. {'code': 'MCP_0000', 'data': data},
  543. )
  544. self.assertTrue(result['is_error'])
  545. def test_export_task_rejects_unsafe_download_urls(self):
  546. urls = (
  547. 'https://user:pass@files.test/a.xlsx',
  548. 'https://files.test/a file.xlsx',
  549. 'https://files.test/a\x00.xlsx',
  550. 'http:foo',
  551. 'ftp://files.test/a.xlsx',
  552. 'https://files.test:bad/a.xlsx',
  553. 'https://files.test:99999/a.xlsx',
  554. 'https://files.test\\evil/a.xlsx',
  555. )
  556. for url in urls:
  557. with self.subTest(url=repr(url)):
  558. result = self.presenter.present(
  559. 'query_export_task',
  560. {
  561. 'code': 'MCP_0000',
  562. 'data': {
  563. 'task_ref': 'mexp_abc',
  564. 'status': 'completed',
  565. 'files': [{'label': 'a.xlsx', 'url': url}],
  566. },
  567. },
  568. )
  569. self.assertTrue(result['is_error'])
  570. def test_known_parameter_error_uses_business_label(self):
  571. result = self.presenter.present(
  572. 'query_track',
  573. {
  574. 'code': 'MCP_1401',
  575. 'msg': 'tracking_number is required',
  576. 'data': {'tracking_number': 'bad'},
  577. 'meta': {'request_id': 'rq_error'},
  578. },
  579. )
  580. self.assertTrue(result['is_error'])
  581. self.assertEqual('快递单号参数不正确', result['structured_content']['message'])
  582. self.assertNotIn('tracking_number', json.dumps(result, ensure_ascii=False))
  583. self.assertEqual({'request_id': 'rq_error'}, result['meta'])
  584. def test_port_export_so_number_error_uses_business_label(self):
  585. result = self.presenter.present(
  586. 'export_out_of_province_port_data',
  587. {
  588. 'code': 'MCP_1401',
  589. 'msg': 'so_numbers must be an array',
  590. 'data': {'so_numbers': 'bad'},
  591. 'meta': {'request_id': 'rq_so_error'},
  592. },
  593. )
  594. self.assertTrue(result['is_error'])
  595. self.assertEqual('SO号参数不正确', result['structured_content']['message'])
  596. self.assertNotIn('so_numbers', json.dumps(result, ensure_ascii=False))
  597. def test_system_error_hides_backend_message_and_data(self):
  598. result = self.presenter.present(
  599. 'query_order_exact',
  600. {
  601. 'code': 'MCP_9001',
  602. 'msg': 'SQLSTATE table st_order order_number failed',
  603. 'data': {'sql': 'select * from st_order'},
  604. },
  605. )
  606. serialized = json.dumps(result, ensure_ascii=False)
  607. self.assertIn('工具调用失败,请稍后重试', serialized)
  608. self.assertNotIn('SQLSTATE', serialized)
  609. self.assertNotIn('st_order', serialized)
  610. self.assertNotIn('order_number', serialized)
  611. def test_new_business_error_codes_have_stable_messages_and_are_not_retryable(self):
  612. cases = {
  613. 'MCP_1103': '员工账号不可用,请联系管理员',
  614. 'MCP_1104': '身份信息已失效,请重新登录或重新生成设备配置',
  615. 'MCP_1501': '目标数据不可用',
  616. 'MCP_1502': '结果过多,请缩小查询范围',
  617. 'MCP_1601': '没有可导出的数据',
  618. }
  619. for code, message in cases.items():
  620. with self.subTest(code=code):
  621. result = self.presenter.present(
  622. 'query_order_exact',
  623. {'code': code, 'msg': 'internal detail', 'data': []},
  624. )
  625. self.assertEqual(code, result['structured_content']['code'])
  626. self.assertEqual(message, result['structured_content']['message'])
  627. self.assertFalse(result['structured_content']['retryable'])
  628. def test_unknown_business_error_code_is_normalized_to_system_error(self):
  629. with self.assertLogs('services.output_presenter', level='WARNING') as logs:
  630. result = self.presenter.present(
  631. 'query_order_exact',
  632. {
  633. 'code': 'MCP_7777',
  634. 'msg': 'secret backend detail',
  635. 'data': [],
  636. 'meta': {'request_id': 'rq_unknown_code'},
  637. },
  638. )
  639. self.assertEqual('MCP_9001', result['structured_content']['code'])
  640. self.assertEqual('工具调用失败,请稍后重试', result['structured_content']['message'])
  641. self.assertTrue(result['structured_content']['retryable'])
  642. self.assertNotIn('secret', json.dumps(result, ensure_ascii=False))
  643. record = logs.records[0]
  644. self.assertEqual('rq_unknown_code', record.request_id)
  645. self.assertEqual('query_order_exact', record.tool_code)
  646. self.assertEqual('MCP_7777', record.backend_code)
  647. self.assertEqual('MCP_9001', record.response_code)
  648. self.assertEqual('UNEXPECTED_EXCEPTION', record.diagnostic_reason)
  649. def test_unknown_tool_and_malformed_success_fail_closed(self):
  650. unknown = self.presenter.present(
  651. 'future_tool',
  652. {'code': 'MCP_0000', 'data': {'secret_field': 'secret'}},
  653. )
  654. malformed = self.presenter.present(
  655. 'query_track',
  656. {'code': 'MCP_0000', 'data': {'records': []}},
  657. )
  658. for result in (unknown, malformed):
  659. self.assertTrue(result['is_error'])
  660. self.assertEqual('工具返回格式异常', result['structured_content']['message'])
  661. self.assertNotIn('secret', json.dumps(result, ensure_ascii=False))
  662. def test_present_exception_maps_value_error_and_hides_unknown_exception(self):
  663. parameter = self.presenter.present_exception(
  664. 'query_track',
  665. ValueError('order_number is required'),
  666. )
  667. system = self.presenter.present_exception(
  668. 'query_track',
  669. RuntimeError('SQL password leaked'),
  670. )
  671. self.assertEqual('订单号参数不正确', parameter['structured_content']['message'])
  672. self.assertEqual('工具调用失败,请稍后重试', system['structured_content']['message'])
  673. self.assertNotIn('password', json.dumps(system, ensure_ascii=False))
  674. def test_present_exception_handles_device_disabled_and_unknown_tool(self):
  675. device = self.presenter.present_exception(
  676. 'query_track',
  677. RuntimeError('这台设备的 Workbuddy 配置已失效,请重新生成配置。'),
  678. )
  679. disabled = self.presenter.present_exception(
  680. 'query_track',
  681. RuntimeError('tool disabled: query_track'),
  682. )
  683. unknown = self.presenter.present_exception(
  684. 'future_tool',
  685. RuntimeError('secret error'),
  686. )
  687. self.assertIn('Workbuddy', device['structured_content']['message'])
  688. self.assertEqual('MCP_1202', disabled['structured_content']['code'])
  689. self.assertEqual('工具返回格式异常', unknown['structured_content']['message'])
  690. def test_invalid_payload_types_and_generic_errors_fail_safely(self):
  691. cases = (
  692. self.presenter.present('query_track', 'invalid'),
  693. self.presenter.present('query_track', {'code': 'MCP_0000', 'data': []}),
  694. self.presenter.present('query_track', {'code': '', 'msg': 'secret'}),
  695. self.presenter.present(
  696. 'query_track',
  697. {'code': 'MCP_7777', 'msg': 'secret backend error'},
  698. ),
  699. self.presenter.present(
  700. 'query_track',
  701. {'code': 'MCP_1301', 'msg': 'secret permission detail'},
  702. ),
  703. )
  704. for result in cases:
  705. self.assertTrue(result['is_error'])
  706. self.assertNotIn('secret', json.dumps(result, ensure_ascii=False))
  707. def test_malformed_table_parts_fail_closed(self):
  708. base = {
  709. 'code': 'MCP_0000',
  710. 'data': {
  711. 'columns': [{'key': 'status', 'name': '状态'}],
  712. 'records': [],
  713. },
  714. }
  715. bad_data = (
  716. {'columns': [], 'records': []},
  717. {'columns': [{'key': 'status', 'name': '状态'}], 'records': None},
  718. {'columns': ['status'], 'records': []},
  719. {'columns': [{'key': None, 'name': '状态'}], 'records': []},
  720. {'columns': [{'key': ' ', 'name': '状态'}], 'records': []},
  721. {'columns': [{'key': 'status', 'name': None}], 'records': []},
  722. {'columns': [{'key': 'status', 'name': ' '}], 'records': []},
  723. {'columns': [{'key': 'status', 'name': '状态'}], 'records': ['bad']},
  724. )
  725. for data in bad_data:
  726. with self.subTest(data=data):
  727. payload = dict(base)
  728. payload['data'] = data
  729. self.assertTrue(self.presenter.present('query_track', payload)['is_error'])
  730. def test_malformed_options_and_exports_fail_closed(self):
  731. cases = (
  732. self.presenter.present(
  733. 'list_order_filter_options',
  734. {'code': 'MCP_0000', 'data': {'records': None}},
  735. ),
  736. self.presenter.present(
  737. 'list_order_filter_options',
  738. {'code': 'MCP_0000', 'data': {'records': ['bad']}},
  739. ),
  740. self.presenter.present(
  741. 'export_pending_outbound_orders',
  742. {
  743. 'code': 'MCP_0000',
  744. 'data': {
  745. 'task_ref': '',
  746. 'status': 'queued',
  747. 'retry_after_seconds': 10,
  748. },
  749. },
  750. ),
  751. self.presenter.present(
  752. 'export_pending_outbound_orders',
  753. {
  754. 'code': 'MCP_0000',
  755. 'data': {
  756. 'task_ref': 'mexp_abc',
  757. 'status': 'queued',
  758. 'retry_after_seconds': 10,
  759. 'extra': True,
  760. },
  761. },
  762. ),
  763. self.presenter.present(
  764. 'export_pending_outbound_orders',
  765. {
  766. 'code': 'MCP_0000',
  767. 'data': {
  768. 'task_ref': 'mexp_abc',
  769. 'status': 'queued',
  770. 'retry_after_seconds': 0,
  771. },
  772. },
  773. ),
  774. )
  775. self.assertTrue(all(result['is_error'] for result in cases))
  776. def test_optional_text_meta_and_nested_values_cover_safe_boundaries(self):
  777. result = self.presenter.present(
  778. 'query_track',
  779. {
  780. 'code': 'MCP_0000',
  781. 'data': {
  782. 'summary': None,
  783. 'columns': [
  784. {'key': 'status', 'name': '状态', 'description': ''},
  785. {'key': 'content', 'name': '详情', 'description': 123},
  786. ],
  787. 'records': [{'status': {'name': '已发货'}, 'content': ['A']}],
  788. 'tips': ['', None, '有效提示'],
  789. },
  790. 'meta': {'request_id': ' ', 'page': 1},
  791. },
  792. )
  793. self.assertFalse(result['is_error'])
  794. self.assertEqual({}, result['meta'])
  795. self.assertIn('{"name": "已发货"}', result['text'])
  796. self.assertIn('["A"]', result['text'])
  797. self.assertEqual(['有效提示'], result['structured_content']['tips'])
  798. no_meta = self.presenter.present(
  799. 'list_order_filter_options',
  800. {'code': 'MCP_0000', 'data': {'records': []}, 'meta': None},
  801. )
  802. self.assertNotIn('pagination', no_meta['structured_content'])
  803. def test_parameter_error_without_known_field_is_generic(self):
  804. result = self.presenter.present(
  805. 'query_track',
  806. {'code': 'MCP_1401', 'msg': 'invalid request'},
  807. )
  808. self.assertEqual(
  809. '工具参数不正确,请检查后重试',
  810. result['structured_content']['message'],
  811. )
  812. def test_query_order_is_explicitly_not_presented(self):
  813. self.assertFalse(self.presenter.handles('query_order'))
  814. self.assertTrue(self.presenter.handles('query_order_exact'))
  815. def test_unhashable_tool_names_fail_closed(self):
  816. for tool_name in ([], {}):
  817. with self.subTest(tool_name=tool_name):
  818. self.assertFalse(self.presenter.handles(tool_name))
  819. result = self.presenter.present_exception(
  820. tool_name,
  821. RuntimeError('secret backend error'),
  822. )
  823. self.assertTrue(result['is_error'])
  824. self.assertEqual(
  825. '工具返回格式异常',
  826. result['structured_content']['message'],
  827. )
  828. def test_safe_tool_descriptions_require_business_labels_only(self):
  829. safe_tools = (
  830. QueryOrderExactTool(),
  831. QueryTrackTool(),
  832. ListOrderFilterOptionsTool(),
  833. ListPendingOutboundExportFilterOptionsTool(),
  834. ExportPendingOutboundOrdersTool(),
  835. ExportOutOfProvincePortDataTool(),
  836. )
  837. for tool in safe_tools:
  838. with self.subTest(tool=tool.name):
  839. self.assertIn('不得展示内部参数名', tool.metadata()['description'])
  840. self.assertNotIn('不得展示内部参数名', QueryOrderTool().metadata()['description'])
  841. def test_presented_order_and_option_values_can_feed_follow_up_tools(self):
  842. class RecordingClient:
  843. def __init__(self):
  844. self.calls = []
  845. def call_tool(self, tool_code, route_path, payload, request_id):
  846. self.calls.append((tool_code, payload))
  847. return {'code': 'MCP_0000'}
  848. order_result = self.presenter.present(
  849. 'query_order_exact',
  850. {
  851. 'code': 'MCP_0000',
  852. 'data': {
  853. 'columns': [{'key': 'order_number', 'name': '订单号'}],
  854. 'records': [{'order_number': 'SO-FOLLOW-UP'}],
  855. },
  856. },
  857. )
  858. option_result = self.presenter.present(
  859. 'list_order_filter_options',
  860. {
  861. 'code': 'MCP_0000',
  862. 'data': {
  863. 'records': [{'value': 901, 'label': '客户甲', 'code': 'C901'}],
  864. },
  865. },
  866. )
  867. client = RecordingClient()
  868. QueryTrackTool(client).call(
  869. order_number=order_result['structured_content']['rows'][0][0],
  870. )
  871. QueryOrderExactTool(client).call(
  872. customer_ids=[option_result['structured_content']['rows'][0][0]],
  873. )
  874. self.assertEqual(
  875. ('query_track', {'page': 1, 'limit': 5, 'order_number': 'SO-FOLLOW-UP'}),
  876. client.calls[0],
  877. )
  878. self.assertEqual([901], client.calls[1][1]['customer_ids'])
  879. if __name__ == '__main__':
  880. unittest.main()